- If you're behind a corporate wall with http only access to the world, you can still use these instructions!
You can't send patches to the mailing list anymore at all. Nowadays you are expected to send patches to the OpenOCD Gerrit GIT server for a review.
Submitting patches to the OpenOCD Gerrit server
OpenOCD is to some extent a "self service" open source project, so to contribute, you must follow the standard procedures to have the best possible chance to get your changes accepted.
The procedure to create a patch is essentially:
- make the changes
- create a commit
- send the changes to the Gerrit server for review
- correct the patch and re-send it according to review feedback
Your patch (or commit) should be a "good patch": focus it on a single issue, and make it be easily reviewable. Don't make it so large that it's hard to review; split large patches into smaller ones. (That can also help track down bugs later on.) All patches should be "clean", which includes preserving the existing coding style and updating documentation as needed.
Say in the commit message if it's a bugfix (describe the bug) or a new feature. Don't expect patches to merge immediately for the next release. Be ready to rework patches in response to feedback.
Add yourself to the GPL copyright for non-trivial changes.
Step by step procedure
- Create a Gerrit account at: http://openocd.zylin.com
- Add a username to your profile. After creating the Gerrit account and signing in, you will need to add a username to your profile. To do this, go to 'Settings', and add a username of your choice. Your username will be required in step 3 and substituted wherever the string 'USERNAME' is found.
- Create an SSH public key following the directions on github: https://help.github.com/articles/generating-ssh-keys . You can skip step 3 (adding key to Github account) and 4 (testing) - these are useful only if you actually use Github or want to test whether the new key works fine.
- Add this new SSH key to your Gerrit account: go to 'Settings' > 'SSH Public Keys', paste the contents of ~/.ssh/id_rsa.pub into the text field (if it's not visible click on 'Add Key ...' button) and confirm by clicking 'Add' button.
- Clone the git repository, rather than just download the source: or if you have problems with the "git:" protocol, use the slower http protocol:
- Set up Gerrit with your local repository. All this does it to instruct git locally how to send off the changes.
- Add a new remote to git using Gerrit username:
Or with http only:
git remote add review ssh:
The http password is configured from your gerrit settings - http://openocd.zylin.com/#/settings/http-password.
git remote add review http:
- If you want to simplify http access you can also add your http password to the url as follows:
git remote add review http:
- You will need to install this hook, we will look into a better solution:
Or with http only:
scp -p -P 29418 USERNAME@openocd.zylin.com:hooks/commit-msg .git/hooks/
mv commit-msg .git/hooks
chmod +x .git/hooks/commit-msg
- A script exists to simplify the two items above. execute:
With <username> being your Gerrit username.
- Set up git with your name and email:
--global user.name "John Smith"
--global user.email "email@example.com"
- Work on your patches. Split the work into multiple small patches that can be reviewed and applied seperately and safely to the OpenOCD repository.
work - edit files using your favorite editor.
run "git commit -s -a" to commit all changes.
run tools/checkpatch.sh to verify your patch style is ok.
Comment template, notice the short first line w/topic. The topic field should identify the main part or subsystem the patch touches. Check git log for examples.
- use "git add ." before commit to add new files.
topic: Short comment
Longer comments over several lines, explaining (where applicable) the
reason for the patch and the general idea the solution is based on,
any major design decisions, etc...
- Next you need to make sure that your patches are on top of the latest stuff on the server and that there are no conflicts:
git pull --rebase origin master
- Send the patches to the Gerrit server for review:
- Forgot something, want to add more? Just make the changes and do:
git commit --amend
git push review
Further reading: http://www.coreboot.org/Git
When can I expect my contribution to be committed?
The code review is intended to take as long as a week or two to allow maintainers and contributors who work on OpenOCD only in their spare time oportunity to perform a review and raise objections.
With Gerrit much of the urgency of getting things committed has been removed as the work in progress is safely stored in Gerrit and available if someone needs to build on your work before it is submitted to the official repository.
Another factor that contributes to the desire for longer cool-off times (the time a patch lies around without any further changes or comments), it means that the chances of quality regression on the master branch will be much reduced.
If a contributor pushes a patch, it is considered good form if another contributor actually approves and submits that patch.
It should be noted that a negative review in Gerrit ("-1" or "-2") may (but does not have to) be disregarded if all conditions listed below are met:
- the concerns raised in the review have been addressed (or explained),
- reviewer does not re-examine the change in a month,
- reviewer does not answer e-mails for another month.
All OpenOCD patches can be reviewed here.
From the main Review page select the patch you want to review and click on that patch. On the appearing page select the download method (top right). Apply the patch. After building and testing you can leave a note with the "Reply" button and mark the patch with -1, 0 and +1.